Template activation: reduce templates listed as options for post/page #72141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +52 B (0%) Total Size: 1.96 MB
ℹ️ View Unchanged
|
ellatrix
added
the
Backport to Gutenberg RC
ellatrix
force-pushed
the
fix/post-template-modal
branch
from
07d31b4 to
4f23323
Compare
|
Flaky tests detected in 4f23323. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18323374394
|
Mamaduka
reviewed
Oct 8, 2025
Comment on lines
76
to
89
| return [ | ||
| ...registeredTemplates, | ||
| ...userTemplates.filter( | ||
| ( template ) => | ||
| // Only give "custom" templates as an option, which | ||
| // means the is_wp_suggestion meta field is not set and | ||
| // the slug is not found in the default template types. | ||
| // https://github.com/WordPress/wordpress-develop/blob/97382397b2bd7c85aef6d4cd1c10bafd397957fc/src/wp-includes/block-template-utils.php#L858-L867 | ||
| ! template.meta.is_wp_suggestion && | ||
| ! defaultTemplateTypes.find( | ||
| ( type ) => type.slug === template.slug | ||
| ) | ||
| ), | ||
| }; | ||
| ]; |
Member
There was a problem hiding this comment.
This is a practice we're trying to discourage and use rarely. It's probably better to do this merging and filtering in useMemo, no?
Member
Author
There was a problem hiding this comment.
Oh that's news to me, why is it discouraged?
Member
There was a problem hiding this comment.
I know it's not the case here, but it's easy to "break" shallow equality checks if you're not careful and manipulate objects/arrays inside the useSelect callback, IMO.
We even introduced a dev warning to catch those early and help third-party developers.
Member
Author
There was a problem hiding this comment.
Hm, but the same can be said of returning an object breaking shallow equality if you nest them. I get your argument, but I think there are valid cases like being able avoid passing values to the render function and avoid re-renders due to value changes. Not super applicable here, but I like avoiding the useMemo call if it's possible like this.
Member
Author
|
Merging because this is blocking GB stable. Let me know if there's concerns and I'll follow up. |
cbravobernal
pushed a commit
that referenced
this pull request
Oct 8, 2025
…#72141) Co-authored-by: ellatrix <[email protected]> Co-authored-by: Mamaduka <[email protected]>
Contributor
|
I just cherry-picked this PR to the release/21.8 branch to get it included in the next release: e266b75 |
cbravobernal
removed
the
Backport to Gutenberg RC
6 tasks
sidharthpandita1
pushed a commit
to sidharthpandita1/gutenberg
that referenced
this pull request
Oct 10, 2025
…WordPress#72141) Co-authored-by: ellatrix <[email protected]> Co-authored-by: Mamaduka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Restores the behaviour from WP 6.8: only actual custom templates should be listed in the template modal for specific posts/pages.
Why?
This is the current WP behavior: when you make edits to a theme template file, the old template or the edit is not visible as an option. Only templates that are "custom" according to the hierarchy can be picked. This is not ideal, but it's a currently limitation because the template property of a post has to be a slug instead of the template ID.
How?
There's actually an error in the changes I made before: the new templates endpoint doesn't have a
post_typequery option because it's a normal post endpoint. That's why I have to expose theis_wp_suggestionmeta (which was not correctly set anymore after the rewrite), which seems to be used currently to determine if a template is custom.A template is custom if
is_wp_suggestionis not set and if the template slug does not appear in the default template types.Testing Instructions
Create a specific template for a certain post, this template should not appear in the template options for other posts.
Duplicate the page template for the theme (or any other template). These user templates should also not appear in the options in the post/page editors.
Now create a "custom" templates (last option) after clicking "Add template". This one should appear in the options!
Testing Instructions for Keyboard
Screenshots or screencast