Icons: Document breaking changes and fix issues from #71878 #72105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +1 B (0%) Total Size: 1.96 MB
ℹ️ View Unchanged
|
Contributor
I think this won't be possible right away, as the following code exists in several places in the Gutenberg codebase: import { edit } from '@wordpress/icons';There are two possible solutions:
|
mcsf
requested review from
ajitbohra,
ellatrix,
fabiankaegy and
getdave
as code owners
youknowriad
reviewed
Oct 6, 2025
* Remove icon symlink from edit.svg to pencil.svg * Document removal of `edit` and `warning` (removed in #71878) * Also add a specific rule in `lint-staged` to generate icons any time the icons library is modified, thereby catching generation errors even in commits that don't modify JS/TS files. (Before this commit, the only way to catch errors was to commit JS/TS files, which would trigger the NPM `prelint` script, which would then call the icon generator.)
mcsf
force-pushed
the
fix/icons-svg-compat-issues
branch
from
2462d1c to
1864958
Compare
t-hamano
approved these changes
Oct 6, 2025
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
LGTM! I confirmed that all warnings have disappeared when running dev or build script.
mcsf
force-pushed
the
fix/icons-svg-compat-issues
branch
from
ed5ab68 to
06b8e31
Compare
t-hamano
reviewed
Oct 6, 2025
... with `pencil` and `cautionFilled`, respectively.
mcsf
force-pushed
the
fix/icons-svg-compat-issues
branch
from
06b8e31 to
0173daf
Compare
Contributor
Author
|
Many thanks for your keen eye, @t-hamano! |
|
Flaky tests detected in 0173daf. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18283771595
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up of #71878
Reported in #71878 (comment) by @t-hamano
edit.svgtopencil.svgeditandwarningicons (removed in aforementioned PR)lint-stagedto (re)generate icons any time the icons library is modified, thereby catching generation errors even in commits that don't modify JS/TS files. (Before this commit, the only way to catch errors was to commit JS/TS files, which would trigger the NPMprelintscript, which would then call the icon generator.)