Add contentRole support to Accordion, Accordion Item, Accordion Panel #72052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Enhancement
t-hamano
requested review from
ajitbohra,
fabiankaegy and
juanmaguitar
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +4 B (0%) Total Size: 1.96 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 4d4f7a0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18271844080
|
andrewserong
approved these changes
Oct 6, 2025
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
In much the same way as we consider the Details block to be content, I agree, I think the Accordion and its blocks need to be thought of the same way 👍
Something that's a bit challenging in terms of usability is that the Accordion block has a fair bit of (necessary) nesting, and so I found the Content panel on the right-hand side to be a bit noisy once there are a few accordion items:
Because of the nature of the nesting and how the panel flattens the hierarchy, to me it's a little hard to see which item or panel I'm within.
That said, I can't quite think of how we'd simplify these blocks for content only mode, as each wrapper needs to be made available — so that we can add additional items, so that we can add headings, and so that we can add multiple blocks within each panel.
For example, on trunk we're stuck with the existing accordion items, and it's not possible to add additional blocks within the accordion panels:
So, all up I think this LGTM (and is necessary for these blocks to be useful in content only mode), but it might be worth getting a second pair of 👀 if there's any concern here.
Thanks for think through how this block works with content only mode!
Contributor
Author
|
@andrewserong Thanks for the review!
For example, we might be able to consider an entire block that supports the |
tellthemachines
approved these changes
Oct 7, 2025
Contributor
tellthemachines
left a comment
tellthemachines
left a comment
There was a problem hiding this comment.
Thanks for the quick follow-up!
Initially I was thinking we only need the role on Accordion and Accordion Panel, because just having it on Accordion means the inserter appears inside the block:
But on reflection (and testing this PR) having Accordion Items be treated as a unit of content that you can duplicate, delete or move provides a better experience.
I think how nesting translates to the inspector view needs more work holistically because it's not an ideal experience for many patterns right now, so adding the extra level has more benefits than downsides 🙂
Contributor
Agreed 👍 |
Contributor
Author
|
Thanks for the review!
Yes, that's why I added the role to the Accordion Item👍 |
sidharthpandita1
pushed a commit
to sidharthpandita1/gutenberg
that referenced
this pull request
Oct 10, 2025
…WordPress#72052) Co-authored-by: t-hamano <[email protected]> Co-authored-by: andrewserong <[email protected]> Co-authored-by: tellthemachines <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds
contentRoleblock support to Accordion, Accordion Item, and Accordion Panel blocks.Why?
The Accordion block is made up of multiple Accordion Item blocks. Many users may think of Accordion Item blocks as content and want to add or remove them. The blocks inside an Accordion Panel can also be considered content.
Testing Instructions for Keyboard
Screenshots or screencast
eceaadd9f54229026e1fd44deac0a034.1.mp4