Template activation: fix /lookup endpoint to use custom resolve fn#72049
Merged
Template activation: fix /lookup endpoint to use custom resolve fn#72049
Conversation
ellatrix
force-pushed
the
fix/template-activation-lookup
branch
from
0ca0d47 to
b45cf60
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 469ba69. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18226813568
|
ellatrix
commented
Oct 3, 2025
| .click(); | ||
| await page.getByRole( 'menuitem', { name: 'Change template' } ).click(); | ||
| await page.getByRole( 'option', { name: 'Custom' } ).click(); | ||
| await expect( |
Member
Author
There was a problem hiding this comment.
This test was previously giving a false positive. It only checks for Single Entries at the very end, but it failed to set the template Custom in the first place.
|
Size Change: -6 B (0%) Total Size: 1.96 MB
ℹ️ View Unchanged
|
Member
Author
|
Merging this because template activation basically doesn't work in the editor. Adjusted the e2e test for better coverage. |
ramonjd
reviewed
Oct 7, 2025
| @@ -0,0 +1,17 @@ | |||
| <?php | |||
|
|
|||
| class Gutenberg_REST_Old_Templates_Controller extends WP_REST_Templates_Controller { | |||
Member
There was a problem hiding this comment.
Hi @ellatrix I need to extend WP_REST_Templates_Controller for another feature.
Can I piggy back off Gutenberg_REST_Old_Templates_Controller?
Could you explain how it relates to Gutenberg_REST_Templates_Controller? Some comments in the code might help folks working on 6.9.
Member
Author
There was a problem hiding this comment.
As we discussed, it would make sense to add the method to override for all 3 controllers if you need to filter templates.
ellatrix
added a commit
that referenced
this pull request
Oct 7, 2025
ellatrix
added
the
Backport to Gutenberg RC
cbravobernal
pushed a commit
that referenced
this pull request
Oct 8, 2025
Contributor
|
I just cherry-picked this PR to the release/21.8 branch to get it included in the next release: 682b5be |
cbravobernal
removed
the
Backport to Gutenberg RC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
The rewrite (#71811) adjusting template resolution use an earlier filter instead of
get_block_templatesshould have also adjusted the/lookupendpoint, which is still using the coreresolve_block_templatefunction. It should use modified version instead.Why?
Currently when you create a new page template and edit a page, that inactive page template will be shown instead of the active theme one. That's because the old resolve template function is still called, and WP thinks that edit should be active.
How?
We override the endpoint callback.
Testing Instructions
Duplicate and edit a page template. Do not activate it. Then create a new page. Use the "show template" preview button. You should see the theme template, not the newly created inactive template.
Testing Instructions for Keyboard
Screenshots or screencast