Template activation: ignore templates not associated with active theme #72029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ellatrix
changed the title
|
Size Change: +121 B (+0.01%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 0e3e18a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18223033886
|
justintadlock
approved these changes
Oct 2, 2025
Contributor
justintadlock
left a comment
justintadlock
left a comment
There was a problem hiding this comment.
After testing, this seems to work as I'd expect.
I created a custom single post template with Twenty Twenty-Five active and tested that it works. When I switched to a new theme, the custom template was automatically deactivated, allowing the new theme's single post template to take precedence. I could then edit my inactive custom template and make it active again.
ellatrix
added
the
Backport to Gutenberg RC
Contributor
|
I just cherry-picked this PR to the release/21.8 branch to get it included in the next release: 034caf7 |
cbravobernal
pushed a commit
that referenced
this pull request
Oct 8, 2025
#72029) Co-authored-by: ellatrix <[email protected]> Co-authored-by: justintadlock <[email protected]>
cbravobernal
removed
the
Backport to Gutenberg RC
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
See #71735.
Addressing feedback from @justintadlock. When the user switches themes, any active templates that are associated with the previous theme should be ignored.
Why?
Currently templates are often heavily dependent on styles and patterns from the current theme.
How?
Whenever new templates are created, we already save information to the database that associates it with the current theme. Fixing the issue is just a matter of using that data:
Please note: when you switched themes previously in WP, theme template edits would completely disappear.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast