Extract shared Controls component for Navigation Link and Submenu blocks#71994
Merged
Extract shared Controls component for Navigation Link and Submenu blocks#71994
Conversation
…ubmenu blocks - Create shared/ directory in navigation-link block - Extract Controls component with identical functionality to original Navigation Link - Add comprehensive tests with pure mocking strategy - Update Navigation Link to use shared Controls component - Maintain all existing functionality including HTML stripping, URL encoding/decoding, and updateAttributes integration - Prepare foundation for Navigation Submenu integration This is step 1 of the DRY refactoring to support Dynamic URL functionality.
… block - Replace duplicated ToolsPanel with shared Controls component - Remove unused imports (CheckboxControl, TextControl, TextareaControl, ToolsPanel, ToolsPanelItem) - Remove unused variables (rel, opensInNewTab) from destructuring - Maintain all existing functionality with simplified code - Complete DRY refactoring for inspector controls Both Navigation Link and Navigation Submenu now use the same shared Controls component.
…irection - Document why the shared directory exists - Explain current shared components and their usage - Outline future vision for unified Navigation Item block - Provide contributing guidelines for shared functionality - Note the balance between current practical solution and long-term architectural goals
…t Shared Components - Remove verbose Files section - Condense Current Shared Components to single bullet point per component - Make README more concise and focused
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
getdave
added
[Type] Code Quality
getdave
changed the title
|
Size Change: -152 B (-0.01%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 9f16ecb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18159553595
|
scruffian
reviewed
Oct 1, 2025
| * @param {Function} props.setAttributes - Function to update block attributes | ||
| * @param {Function} props.setIsEditingControl - Function to set editing state (optional) | ||
| */ | ||
| export function Controls( { |
Contributor
There was a problem hiding this comment.
There are a few differences between the components, so the refactor should deal with some bugs also, for example Navigation Link: sanitizes Text, decodes/encodes Link URLs, defers updateAttributes on blur, manages an editing state to stabilize focus/UX.
This change adds all those features to Navigation Submenu, which is good :)
Contributor
Author
There was a problem hiding this comment.
Yeh and it really proves the point and validates the need for this PR over and above the immediately utility for landing the Dynamic URLs piece.
scruffian
approved these changes
Oct 1, 2025
Contributor
scruffian
left a comment
scruffian
left a comment
There was a problem hiding this comment.
This is working well in my testing. Seems like a good opportunity to refactor in service of a larger goal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR refactors the Navigation Link and Navigation Submenu blocks to reduce code duplication by extracting shared inspector controls functionality into a reusable component.
Supports #71630
Why
Supporting Dynamic URL Functionality
This refactoring is a prerequisite for integrating the Dynamic URL functionality developed in PR #71630. The Dynamic URL feature uses the Block Bindings API to make Navigation Link URLs dynamic when linking to entities (Pages, Posts, etc.), ensuring links don't break when permalinks change.
Code Quality Improvements
How
Created a shared
Controlscomponent that encapsulates the commonToolsPanelfunctionality used by both navigation blocks. The component maintains all original functionality including URL handling, entity link management, and user interactions.Testing
1. Inspector Controls (Settings Panel)
2. Entity Link Handling
3. Frontend Verification
4. Cross-Block Testing
5. Regression Testing
Future Direction
This refactoring prepares the foundation for:
Backward Compatibility