Block Comment: Improve comment thread outline#71961
Merged
Conversation
t-hamano
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +30 B (0%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Sep 30, 2025
|
Flaky tests detected in 096ffc5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18115657214
|
t-hamano
added
[Feature] Notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR will apply the correct style based on the design, depending on the state of the comment thread.
How?
At the same time, this PR avoided hard-coded values and used SCSS variables.
Testing Instructions
Click on the block, click on the comment, or focus on the comment with your keyboard to see the outline.
Screenshots or screencast
Note that in the following screenshots and screencast, the focus outline width is 2px, as my laptop doesn't have a high-resolution screen. If you're using a Retina Mac, the outline width should probably be 1.5px.
576d8110a022d292ad05ba83b2e621be.mp4