Conversation
This may be my smallest PR yet. But it is still a PR dangit, and it deserves the same thorough and exhaustive reviews as any other PRs do. It deserves CPU time on travis to run thousands of unrelated tests. It deserves this because it is right. As such, this pull request aims to fix an issue with the Cover Image block. Specifically, if you look at the description of the block in the sidebar block inspector, you will notice that the description features a --, two dashes, where it should feature an emdash, i.e. —. I can't believe an issue for this hasn't been opened, but in any case, now it's fixed. Steps to reproduce: - Insert a Cover Image block - Add an image and title to it, or don't - Open the sidebar, or in case it's already opened, leave it open - Select the cover image block, or in case it's already selected, leave it selected - Note that the description shows a -- instead of a — Tests: - Apply this PR - Repeat the steps above - Now verify the -- is inded a — instead - Verify that there are no regressions as a result of this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This may be my smallest PR yet. But it is still a PR dangit, and it deserves the same thorough and exhaustive reviews as any other PRs do. It deserves CPU time on travis to run thousands of unrelated tests. It deserves this because it is right.
As such, this pull request aims to fix an issue with the Cover Image block. Specifically, if you look at the description of the block in the sidebar block inspector, you will notice that the description features a --, two dashes, where it should feature an emdash, i.e. —. I can't believe an issue for this hasn't been opened, but in any case, now it's fixed.
Steps to reproduce:
Tests:
Screenshots
Before:
After:
GIF:
Checklist: