The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <[email protected]>
Co-authored-by: mirka <[email protected]>
Co-authored-by: jasmussen <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Size Change: -132 B (-0.01%)

Total Size: 2.37 MB

_{compressed-size-action}

I agree with all the assessments noted above.

If I recall correctly, the original design called for a select, an actual select. If that's not doable, I don't mind replacing this with a button. Probably secondary style.

Any other recommendations?

I don't mind replacing this with a button. Probably secondary style.

Although this is still an experimental UI, the inserted pattern now has the button inside the block card:

Given that, I used the same style of button for the transforms toggle, too (centered, 40px height, and secondary varian). What do you think?

That would be the idea.

I think the edit contents button may be too prominent, actually, I could see it going away again. At the same time, I proposed it. But I think it's more valid for this case. I think the block to test is actually navigation items, I think they have a pretty packed inspector already.

Flaky tests detected in 4209bcf.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18927031828
📝 Reported issues:

• [Flaky Test] Should navigate to template part and back. #69470 in /test/e2e/specs/site-editor/template-part-focus-mode.spec.js
• [Flaky Test] ensures List View global shortcut works properly #51533 in /test/e2e/specs/editor/various/list-view.spec.js

This UI was first implemented in #26687, but it seems that several designs were considered. See #26687 (comment)

My other suggestion would be to use the CustomSelectControl, but that might be too prominent:

I'll defer to you all on which component to use. But it's also on my mind that the CustomSelectControl feels a bit dated at this point. Isn't that the old version of the control proposed?

the CustomSelectControl feels a bit dated at this point. Isn't that the old version of the control proposed?

I know there is a newer CustomSelectControlV2, but this doesn't seem to be used anywhere in the project yet 🤔

I prefer the menu UI over a select UI here, since transforming to another block is an action, not a parameter of the Post Date block itself. So basically what @t-hamano suggested here 👍

But it's also on my mind that the CustomSelectControl feels a bit dated at this point. Isn't that the old version of the control proposed?

Unrelated to this PR now, but it's likely we'll abandon CustomSelectControlV2 entirely, and replace it with a single new SelectControl that supports custom rendering. But I'm planning to do some cosmetic updates on CustomSelectControl anyway so it doesn't look out of place.

Are we good to merge this PR? As originally planned, this pull request refactors the UI using a Menu component while maintaining the traditional button design as much as possible.