-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Post Editor: Add the back button animation similar to the site editor #71929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Size Change: +392 B (+0.02%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 649e801. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18061014271
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ellatrix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, you don't think it makes sense to have a reusable editor component for this?
|
I don't really know where to put a reusable component and I don't feel like creating a package just for it. |
|
Ideally both edit-post and edit-site should be the same package but that is not something we can solve now. |
What
Bring edit-site's back button hover animation to edit-post editor. The animation shows an arrow overlay on hover while the site icon clips inward with smooth transitions.
Changes
Just copied the exact same styles. I don't think it's worth building a shared UI component for this yet.