Block Comments: Apply border color to avatar#71917
Merged
Conversation
t-hamano
added
[Type] Enhancement
t-hamano
force-pushed
the
block-comment/avatar-color
branch
from
edbfcd6 to
530a565
Compare
|
Size Change: +163 B (+0.01%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 530a565. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18028986698
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
reviewed
Sep 26, 2025
Comment on lines
+32
to
+34
| export function getAvatarBorderColor( userId ) { | ||
| return AVATAR_BORDER_COLORS[ userId % AVATAR_BORDER_COLORS.length ]; | ||
| } |
Mamaduka
approved these changes
Sep 26, 2025
Member
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
Looks great and works as expected ✅
Contributor
Author
|
Thanks for the review, @Mamaduka! If we find a better logic, let's try it as a follow-up. We can also update the color list if necessary. |
Contributor
Appreciate that, and this work. |
t-hamano
added
[Feature] Notes
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to address #71774 (comment)
What?
Attempts to automatically apply the avatar's border color.
How?
Deciding what rules to use to generate colors is a very difficult problem, but in this PR I'm trying the following approach.
The advantage of this approach is that it ensures that colors will remain consistent for each user across the WordPress site, since the color is calculated from only user ID.
The downside is that we may not get a wide range of color variations, for example, user IDs 8, 16, 24, and 32 will all have the same color.
Any ideas on other approaches are welcome!
Testing Instructions