Time to Read: Replace toggles with block variations#71897
Merged
ntsekouras merged 14 commits intotrunkfrom Sep 30, 2025
Merged
Conversation
scruffian
requested review from
ajitbohra,
fabiankaegy and
juanmaguitar
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +34 B (0%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
t-hamano
reviewed
Sep 25, 2025
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Personally, I prefer to remove the "Both" option:
- Users who want both pieces of information can simply insert two of these blocks.
- The "Both" option can be confusing, as the full text is not visible unless you open the dropdown.
What do you think?
t-hamano
added
[Type] Enhancement
Contributor
Author
Maybe these are really two different blocks then? |
Contributor
|
Another approach might be to add word count as a block variation, similar to how the Post Date block has a Modified Date block as a variation. I don't have a strong opinion on what approach is best 🤔 |
Contributor
|
It might be a good idea to get some design feedback on this PR. The current Time to Read block has independent toggle controls for reading time and word count: 
This PR changes those toggles to dropdowns, forcing at least one option to be enabled: 
An alternative approach might be to create a block variation called "Word Count" to display the word count. What do you think? |
github-project-automation
bot
moved this to 🔎 Needs Review
in WordPress 6.9 Editor Tasks
Contributor
|
One block inserted twice, or separate blocks, both afford a little customizability as far as apparance, insofar as you might insert both in a row block and put your own separator between them, or something else. Not a strong opinion, but past experience tells me this flexibility is welcomed by theme designers. |
scruffian
changed the title
scruffian
force-pushed
the
update/time-to-read-display-options
branch
from
72570d7 to
e07a79b
Compare
Contributor
Author
|
I've updated this to use a block variation. |
t-hamano
reviewed
Sep 29, 2025
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the update.
Not a blocker, but should we update the icon for the Word Count block variation? This is because the "clock" icon is used in both blocks.
Co-authored-by: Aki Hamano <[email protected]>
Co-authored-by: Aki Hamano <[email protected]>
Co-authored-by: Aki Hamano <[email protected]>
Contributor
Author
Yeah I think so, but not sure what to use! |
Contributor
Maybe @jasmussen or @jameskoster can help with an icon. Having different icons will also render the icons for variation switcher in inspector controls. |
ntsekouras
reviewed
Sep 29, 2025
| displayAsRange, | ||
| showTimeToRead, | ||
| showWordCount, | ||
| displayMode, |
Contributor
There was a problem hiding this comment.
Not from this PR, but as I was checking this file I saw that the return parts.map( ( part, index ) => ( part above is not needed. We always push one item to parts array, so we should directly return the value in each if block that we now do parts.push
Contributor
|
@scruffian Finally, can we fix the unit test that is failing? |
ntsekouras
reviewed
Sep 29, 2025
t-hamano
reviewed
Sep 30, 2025
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
LGTM!
Let's merge this PR first and follow up with code quality improvements and icon changes.
Because not including this PR in Gutenberg 21.8 will cause backward compatibility issues. The 21.8 RC release process should start within the next 1-2 days. See #71897 (comment)
t-hamano
approved these changes
Sep 30, 2025
github-project-automation
bot
moved this from 🔎 Needs Review
to ✅ Done
in WordPress 6.9 Editor Tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and Why?
Based on this feedback, I changed the way this block works so that its not possible to remove all content from the block.
How?
Replaces the toggles with block variations
Testing Instructions
Screenshots or screencast