Block Comments: Fix translation comments to say participants in toolbar indicator#71890
Merged
talldan merged 2 commits intoWordPress:trunkfrom Sep 25, 2025
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
talldan
added
[Package] i18n
talldan
reviewed
Sep 25, 2025
| : sprintf( | ||
| // translators: %s: Number of comments. | ||
| // translators: %s: Number of participants. | ||
| __( '+%s more participants' ), |
Contributor
There was a problem hiding this comment.
Although I approved the comment change, I wonder if this should use _n to handle pluralization 🤔
Contributor
Author
There was a problem hiding this comment.
Yes that'll be a lot better...
t-hamano
added
[Feature] Notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Stemming from #71271
Addressed at https://wordpress.slack.com/archives/C02QB2JS7/p1758767400095899?thread_ts=1758754813.891189&cid=C02QB2JS7
In #71271, incorrect translator comments were left out that convey the count is for comments whereas they are for displaying participants.
While working on it, at one point the code used to display number of comments instead of participants.
I must've missed reverting the comment to participants...
Thanks to @talldan for bringing up the issue 🙌
Why?
Incorrect translation comments can cause confusion to translators & lead to incorrect translations.
How?
PR fixes the instances of incorrect translation labels.