Accordion Header: Remove textAlignment and textAlign#71875
Merged
Conversation
mikachan
requested review from
ajitbohra,
fabiankaegy and
juanmaguitar
as code owners
mikachan
added
[Type] Enhancement
9 tasks
|
Size Change: -49 B (0%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
t-hamano
approved these changes
Sep 24, 2025
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
LGTM!
To be honest, I'd also like to remove the textAlign block support. The reason is that block instances cannot override global styles. This is also why no other core blocks have textAlign block support. See this comment for more details.
What do you think about removing textAlign block support as a follow-up?
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 6ef2d7c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18005965885
|
Member
Author
Ah thanks, I didn't realise that there are no other blocks with |
Contributor
I think we can do it in this PR 👍 |
Contributor
|
Thanks for the update 🚢 |
mikachan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Addresses part of #71732.
Why?
We don't need the
textAlignmentattribute, astextAlignsupport is already available via the typography block supports.How?
Removes the
textAlignmentattribute from the Accordion Header block, and also removes some unusedtextAlignlogic.Also removes the
clsximport, as it's no longer being used here.Testing Instructions