Fix comment counts with filter#71874
Merged
adamsilverstein merged 9 commits intoWordPress:trunkfrom Sep 26, 2025
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
adamsilverstein
added
[Type] Bug
github-project-automation
bot
moved this to 🔎 Needs Review
in WordPress 6.9 Editor Tasks
adamsilverstein
moved this from 🔎 Needs Review
to 🏗️ In Progress
in WordPress 6.9 Editor Tasks
Mamaduka
reviewed
Sep 25, 2025
Mamaduka
approved these changes
Sep 25, 2025
Member
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
A bit tricky filter, but I don't see any other way to override core behavior in the plugin unless we ignore it.
This works well in my tests.
github-project-automation
bot
moved this from 🏗️ In Progress
to ✅ Done
in WordPress 6.9 Editor Tasks
t-hamano
added
[Feature] Notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fix an issue with comment counts showing block_comments as part of the counted comments (specifically the pending comments in the red dots).
Closes #71621
Screenshots or screencast
Note in the before image the counts in the red dot are actually Editorial (Inline block) comments, not front end comments. These are inaccurately shown.