Block Comments: Fix canceling the form for a selected block#71862
Merged
Block Comments: Fix canceling the form for a selected block#71862
Conversation
Mamaduka
added
[Type] Bug
Mamaduka
changed the title
|
Size Change: -55 B (0%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 214565a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17966852373
|
t-hamano
approved these changes
Sep 24, 2025
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Nice refactoring 🎉I don't see any regressions in this PR.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
t-hamano
added
[Feature] Notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #71308.
PR fixes the bug and allows canceling the reply for the currently selected block.
I also did the following refactoring of internal components:
focusThreadvalue. It wasn't required and was causing the mentioned bug.Comments.Why?
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast
Before
CleanShot.2025-09-24.at.09.04.58.mp4
After
CleanShot.2025-09-24.at.09.02.23.mp4