Skip to content

Navigation Block: Use path for all navigation toogle icons#71829

Merged
t-hamano merged 1 commit intoWordPress:trunkfrom
Drivingralle:Use_path_for_all_navigation_toogle_icons
Sep 24, 2025
Merged

Navigation Block: Use path for all navigation toogle icons#71829
t-hamano merged 1 commit intoWordPress:trunkfrom
Drivingralle:Use_path_for_all_navigation_toogle_icons

Conversation

@Drivingralle
Copy link
Contributor

What?

Third option to Closes #71791

How?

Use path tag for all menu icons

Testing Instructions

  1. Add a navigation block to website
  2. Set the navigation block to show the Menu icon
  3. Inspect the menu icon
  4. Change the icon to show Handle icon

@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Drivingralle <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Sep 22, 2025
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Drivingralle! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@t-hamano t-hamano added [Type] Code Quality Issues or PRs that relate to code quality [Block] Navigation Affects the Navigation Block labels Sep 23, 2025
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I confirmed there are no visual changes:

Image

@t-hamano t-hamano closed this Sep 23, 2025
@t-hamano t-hamano reopened this Sep 23, 2025
@t-hamano t-hamano changed the title Use path for all navigation toogle icons Navigation Block: Use path for all navigation toogle icons (#71829) Sep 24, 2025
@t-hamano t-hamano changed the title Navigation Block: Use path for all navigation toogle icons (#71829) Navigation Block: Use path for all navigation toogle icons Sep 24, 2025
@t-hamano t-hamano merged commit a4988ec into WordPress:trunk Sep 24, 2025
141 of 179 checks passed
@github-actions github-actions bot added this to the Gutenberg 21.8 milestone Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Navigation Affects the Navigation Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split Hamburger-Icon SVG into three tags to allow more styling and animation

2 participants