Template activation: fix saveEntityRecord with theme ID#71798
Merged
Template activation: fix saveEntityRecord with theme ID#71798
Conversation
ellatrix
force-pushed
the
fix/template-activation-save-entity-record
branch
from
3ca940d to
e05779a
Compare
|
Size Change: +81 B (0%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
Author
|
I'll add an e2e test for this |
ellatrix
force-pushed
the
fix/template-activation-save-entity-record
branch
from
e05779a to
2c93cfb
Compare
Member
Author
|
Ok, let's merge this so it's in before RC tomorrow. It's been tested manually by @kmanijak and added an e2e test, so should be fine. Happy to adjust things if needed. |
9 tasks
ellatrix
added a commit
that referenced
this pull request
Nov 5, 2025
…)" This reverts commit b58483e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #71765
Why?
saveEntityRecorderrors when called with a theme ID.How?
When called with a theme ID, we should handle creating a template and activate it.
Testing Instructions
Run:
It should not error, create a template, and activate it.
Testing Instructions for Keyboard
Screenshots or screencast