Merged
Conversation
… causing console errors
ntsekouras
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
priethor
approved these changes
Sep 21, 2025
Contributor
priethor
left a comment
priethor
left a comment
There was a problem hiding this comment.
Works as expected, the error is gone ✅
|
Size Change: -2 B (0%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
ntsekouras
changed the title
__nextHasNoMarginBottom property causing console errors
ntsekouras
deleted the
fix/__nextHasNoMarginBottom-in-terms-query-block
branch
adamsilverstein
pushed a commit
to adamsilverstein/gutenberg
that referenced
this pull request
Sep 22, 2025
* Terms Query: Small fix of not used `__nextHasNoMarginBottom` property causing console errors * proper fetiching of taxonomis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Small bug fix that removes the unused
__nextHasNoMarginBottomin RadioControl inDisplayOptionsof terms query block.Additionally updates how we fetch the taxonomies in inspector controls to avoid the different instances inside
useSelect. Also uses the same logic for fetching the taxonomies as we do inusePublicTaxonomiesin site editor.Testing Instructions
Terms Queryblock and open the inspector controls__nextHasNoMarginBottom, as opposed to trunk