Accordion Header: Remove hardcoded inline styles and unused CSS class #71731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -40 B (0%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in b49149c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17827511647
|
mikachan
approved these changes
Sep 18, 2025
Member
mikachan
left a comment
mikachan
left a comment
There was a problem hiding this comment.
These inline styles and CSS classes are likely intended to prepare us for icon customization in the future.
Yes, that's correct. We can add this functionality back when we add icon customisation.
I can't see any visual changes introduced in this PR:
| trunk | This PR |
|---|---|
 |
 |
Nice cleanup, thanks @t-hamano!
9 tasks
Contributor
Author
|
@mikachan thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes hardcoded inline styles and unused CSS classes from the Accordion Header block.
Why?
These inline styles and CSS classes are likely intended to prepare us for icon customization in the future.
However, currently, that functionality doesn't exist. Furthermore, changing these styles would break the block, which would require the effort of adding a block deprecation.
For now, I think it's best to make the block robust and remove any unnecessary code. If and when icon customization becomes necessary, we can reconsider the design at that time.
Testing Instructions
Smoke test the Accordion block. There should be no visual changes.