Make sure "add page" button label only appears once #71710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
requested review from
ajitbohra,
ellatrix and
fabiankaegy
as code owners
tellthemachines
requested review from
getdave
and removed request for
ajitbohra,
ellatrix and
fabiankaegy
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tellthemachines
added
[Type] Bug
|
Size Change: +29 B (0%) Total Size: 1.94 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 3ccec97. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17787042522
|
Contributor
|
Thanks @tellthemachines for continuing to test thoroughly in the text only version of the interface 👏 |
Contributor
Author
No worries, I do it for purely selfish reasons 😄 (it's my preferred mode) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes Add page button introduced in #71192 when button text labels are enabled.
The addition of "title" to
ToolbarButtonadds it as an aria-label to the underlying button, and aria-labels are output when text labels are enabled. Given the button has text, it doesn't need an aria-label.This PR removes the aria-label, and also makes a small adjustment to text label styles so they don't take effect when the button has both icon and text.
Testing Instructions
"contentRole": trueto the Nav block supports (or follow the testing steps in Add Navigation Add Page Button #71192)