Section block multi-selection: disable transforms and inspector controls #71708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
4 tasks
ramonjd
added
[Feature] Block Multi Selection
ramonjd
requested review from
Mamaduka,
aaronrobertshaw,
andrewserong,
talldan and
tellthemachines
ramonjd
commented
Sep 17, 2025
|
Size Change: +57 B (0%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
tellthemachines
approved these changes
Sep 17, 2025
Contributor
tellthemachines
left a comment
tellthemachines
left a comment
There was a problem hiding this comment.
Change LGTM! Testing as expected.
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
This is testing well for me, too! Didn't run into any issues 👍
Member
Author
|
E2E test fails seem related. Will look into it tomorrow. |
Mamaduka
reviewed
Sep 17, 2025
…r multiple selected blocks and updating section block checks.
…lected blocks by utilizing `getSelectedBlockClientIds`.
…irectly, simplifying the logic for identifying section blocks in the selection.
ramonjd
force-pushed
the
update/disable-inspector-multi-sections
branch
from
f0aa494 to
5bd9f06
Compare
…to improve handling of multiple selected blocks, ensuring accurate identification of section blocks in selection.
Member
Author
Oversight on my part - the Should be fixed now. No other changes to functionality. If the tests pass I'll 🚢 |
|
Flaky tests detected in 8a109fb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17817433708
|
This was referenced Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #71709
Part of #71517
Context: #71512 (comment)
This PR disables transforms and inspector controls when one or more or all blocks in multi-selection are "section blocks".
Why?
As part of #71517, a "section block" — for example patterns or template parts — is displayed in content only mode.
Content only mode describes an editing mode in which the inner block tree of section blocks are filtered to only display common content blocks, and with limited editing in the toolbar and inspector sidebar.
The different toolbar and inspector states of section blocks make them incompatible with regular blocks.
The idea is to make things more consistent with other "incompatible" multi-block combinations - in these cases
nblocks is displayed only in the sidebar.How?
Checking for section blocks in the
getSelectedBlockClientIds()return value (Array).Testing Instructions
Switch on the patterns + content only experiment:
Screenshots or screencast
Before
Kapture.2025-09-17.at.14.12.04.mp4
After
Kapture.2025-09-17.at.13.53.44.mp4