Skip to content

Improve comments panel close icon label #71701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
t-hamano merged 2 commits into from
Sep 18, 2025
Merged

Improve comments panel close icon label #71701

t-hamano merged 2 commits into from
Sep 18, 2025

Conversation

@adamsilverstein
Copy link
Member

@adamsilverstein adamsilverstein commented Sep 16, 2025 •
edited
Loading

What?

Adds a label for the close icon of the comments sidebar panel.

Fixes #71700

Why?

The current default label "Close plugin" doesn't make sense.

How?

Adding a label.

Testing Instructions

  1. Open the comments sidebar and hover over the close icon

Testing Instructions for Keyboard

Screenshots or screencast

Before:
image

After:
image

@github-actions
Copy link

github-actions bot commented Sep 16, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: adamsilverstein <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-project-automation github-project-automation bot moved this to 🔎 Needs Review in WordPress 6.9 Editor Tasks Sep 16, 2025
@t-hamano
Copy link
Contributor

t-hamano commented Sep 16, 2025

Considering consistency with other labels, what about "Close Comments"? (Capital Case, and without the word "panel")

Close Settings:

image

Close Styles:

image

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. Collaborative Workflows Phase 3 of the Gutenberg roadmap around all-things related to collaborative workflows labels Sep 16, 2025
@Mamaduka
Copy link
Member

Mamaduka commented Sep 16, 2025

Good point, @t-hamano. Let’s keep it consistent.

@adamsilverstein
Copy link
Member Author

adamsilverstein commented Sep 17, 2025

Makes sense, thanks for the feedback- will update.

@adamsilverstein
Copy link
Member Author

adamsilverstein commented Sep 17, 2025 •
edited
Loading

Considering consistency with other labels, what about "Close Comments"? (Capital Case, and without the word "panel")

👍🏼 Updated in ccd784b

@t-hamano t-hamano merged commit 2740fd4 into WordPress:trunk Sep 18, 2025
77 of 78 checks passed
@github-project-automation github-project-automation bot moved this from 🔎 Needs Review to ✅ Done in WordPress 6.9 Editor Tasks Sep 18, 2025
@github-actions github-actions bot added this to the Gutenberg 21.8 milestone Sep 18, 2025
@t-hamano t-hamano added [Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting and removed Collaborative Workflows Phase 3 of the Gutenberg roadmap around all-things related to collaborative workflows labels Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@t-hamano t-hamano Awaiting requested review from t-hamano

Assignees

No one assigned

Labels

[Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting [Type] Enhancement A suggestion for improvement.

Projects

WordPress 6.9 Editor Tasks
Status: ✅ Done

Milestone

Gutenberg 21.8

Development

Successfully merging this pull request may close these issues.

"Close Plugin" language for comment sidebar is confusing

3 participants

@adamsilverstein @t-hamano @Mamaduka