-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Block Comments: Improve error handling for core data actions #71695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +8 B (0%) Total Size: 1.94 MB
ℹ️ View Unchanged
|
t-hamano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice enhancement! While working on #71682, I was wondering why messages defined in the REST API were not being displayed on the client side.
What?
PR updates C(R)UD actions for block comments to use
try...catchfor error handling and display error messages provided from the server when available.I've also changed the error notice to a Snackbar to avoid a canvas jump on error.
P.S. I think we can combine edit methods into a single callback, but I'm going to work on that separately to make testing easier.
Why?
Follows practices used across the editor for similar actions.
Testing Instructions
Testing patch
Testing Instructions for Keyboard
Same.