DataForm select control: support validation#71665
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 6b0c1bd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17736188398
|
andrewserong
left a comment
There was a problem hiding this comment.
Tests well for me!
✅ Custom validation state works as expected (must select Option 1)
✅ Required validation state works as expected
✅ Toggling both off works as expected
LGTM!
Part of #71500
What?
Add support for
requiredandcustomvalidation in the select control.Why?
So that all controls support basic validation.
How?
Use the existing
ValidatedSelectControlcomponent.Testing Instructions
In the storybook (
npm run storybook:dev) verify that it can takerequiredandcustomvalidation in the "DataViews > DataForm > Validation" story:Screen.Recording.2025-09-15.at.16.12.51.mov