Block Editor: fix BlockSwitcher to prevent transforms on reusable blocks #71661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
added
[Type] Bug
Mamaduka
reviewed
Sep 16, 2025
Comment on lines
111
to
116
| const isReusable = isSingleBlock && isReusableBlock( blocks[ 0 ] ); | ||
| const hasPossibleBlockTransformations = | ||
| !! possibleBlockTransformations.length && canRemove && ! isTemplate; | ||
| !! possibleBlockTransformations.length && | ||
| canRemove && | ||
| ! isTemplate && | ||
| ! isReusable; |
Member
There was a problem hiding this comment.
Let's generalize the check and update the comment above; otherwise, it looks outdated.
Here's an example diff:
diff --git a/packages/block-editor/src/components/block-switcher/index.js b/packages/block-editor/src/components/block-switcher/index.js
index 8bd02e9357d..537d919c270 100644
--- a/packages/block-editor/src/components/block-switcher/index.js
+++ b/packages/block-editor/src/components/block-switcher/index.js
@@ -102,18 +102,16 @@ function BlockSwitcherDropdownMenuContents( {
selectForMultipleBlocks( transformedBlocks );
}
/**
- * The `isTemplate` check is a stopgap solution here.
+ * The `isSynced` check is a stopgap solution here.
* Ideally, the Transforms API should handle this
* by allowing to exclude blocks from wildcard transformations.
*/
const isSingleBlock = blocks.length === 1;
- const isTemplate = isSingleBlock && isTemplatePart( blocks[ 0 ] );
- const isReusable = isSingleBlock && isReusableBlock( blocks[ 0 ] );
+ const isSynced =
+ isSingleBlock &&
+ ( isTemplatePart( blocks[ 0 ] ) || isReusableBlock( blocks[ 0 ] ) );
const hasPossibleBlockTransformations =
- !! possibleBlockTransformations.length &&
- canRemove &&
- ! isTemplate &&
- ! isReusable;
+ !! possibleBlockTransformations.length && canRemove && ! isSynced;
const hasPossibleBlockVariationTransformations =
!! blockVariationTransformations?.length;
const hasPatternTransformation = !! patterns?.length && canRemove;
shrivastavanolo
force-pushed
the
fix/remove-transforms-for-synced-patterns
branch
from
c76417a to
785399a
Compare
Mamaduka
approved these changes
Sep 16, 2025
Member
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
Thanks for working on this, @shrivastavanolo!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #67710
This PR updates the BlockSwitcher component to disable block transformations for reusable (synced) blocks. Template parts were already excluded; now reusable blocks will also hide transform options in the dropdown.
Why?
Currently, the BlockSwitcher allows transformations on reusable blocks. Transforming a reusable block can cause unexpected behavior, since all instances of the block are linked. Preventing transforms for these blocks ensures consistency across instances and prevents accidental data loss.
See #67710 (comment)
How?
Testing Instructions
Screenshots or screencast
Before
Screen.Recording.2025-09-15.at.5.25.00.PM.mov
After
Screen.Recording.2025-09-15.at.5.24.30.PM.mov