Terms Query: Combine Order and Order By control into single dropdown + remove order by slug.#71656
Merged
mikachan merged 1 commit intoWordPress:trunkfrom Sep 17, 2025
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mikachan
added
[Type] Enhancement
mikachan
approved these changes
Sep 17, 2025
Member
mikachan
left a comment
mikachan
left a comment
There was a problem hiding this comment.
I also removed order by slug as I can't really see a use case for it and if so, I treat it a UI pollution.
This makes sense; makes the UI look cleaner.
This works as described, and the code looks good, great job! 🚢
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes
Combine Order and Order By control into single dropdown. cc: @mikachan
Why?
Dropdowns occupy quite a lot of space in Inspector Controls and are pretty heavy. There's no need for separate dropdown for Order and OrderBy while it can be easily combined. Agreed in this comment.
I also removed order by slug as I can't really see a use case for it and if so, I treat it a UI pollution.
How?
Testing Instructions
Name: A → ZTesting Instructions for Keyboard
Screenshots or screencast