Core Commands: Introduce new useCommands hook#71603
Merged
Conversation
t-hamano
added
[Type] New API
|
Size Change: +51 B (0%) Total Size: 1.94 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
approved these changes
Sep 11, 2025
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
This works for me.
I believe ultimately we need to move to a command palette powered by abilities to unify shortcuts/commands and AI but for the existing API, I think this is a nice addition.
Contributor
Author
|
Thanks for the review!
I agree, I don't have any idea yet on how to integrate the Commald Palette and the Abilities API, but I'd like to try to work on that in the feature. |
|
Flaky tests detected in c2fd175. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17640267452
|
adamsilverstein
pushed a commit
to adamsilverstein/gutenberg
that referenced
this pull request
Sep 11, 2025
* Core Commands: Introduce new useCommands hook * Add example Co-authored-by: t-hamano <[email protected]> Co-authored-by: youknowriad <[email protected]>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR proposes to introduce a new
useCommandshook.Why?
The
useCommandhook (widthouts) can only be used to register a single static command. Therefore, registering multiple static commands is a bit tedious - consumers have to use the "useCommandLoader" hook even though all the commands are static.How?
Introduces the new
useCommandshook that allows consumers to register multiple static commands at once. Additionally, I refactored the code that registers menu commands with this new hook.I'd love to hear your feedback on whether you find this new hook useful.
Testing Instructions
Commands based on the Menu API are now registered via this new hook, so make sure "Go to: ..." commands still works as before.