Backport: Avoid warning for non-string class attributes. #71594
Merged
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
dmsnell
force-pushed
the
backport/block-supports-background-non-string-attribute-check
branch
2 times, most recently
from
bd1ecb6 to
d994faf
Compare
dmsnell
added a commit
that referenced
this pull request
Sep 10, 2025
Trac ticket: Core-59622 This is a backport of WordPress/wordpress-develop#5486, which introduces an additional check for non-string values of the `class` attribute when rendering background support for blocks. This check avoids issuing a warning when a boolean `true` value of the attribute is passed on to `str_ends_with()`. Co-authored-by: Tonya Mork <[email protected]> Co-authored-by: Peter Wilson <[email protected]> Co-authored-by: Jon Surrell <[email protected]> Github-PR: 71594 Github-PR-URL: #71594 Branch-name: backport/block-supports-background-non-string-attribute-check
dmsnell
added a commit
that referenced
this pull request
Sep 10, 2025
Trac ticket: Core-59622 This is a backport of WordPress/wordpress-develop#5486, which introduces an additional check for non-string values of the `class` attribute when rendering background support for blocks. This check avoids issuing a warning when a boolean `true` value of the attribute is passed on to `str_ends_with()`. Co-authored-by: Tonya Mork <[email protected]> Co-authored-by: Peter Wilson <[email protected]> Co-authored-by: Jon Surrell <[email protected]> Github-PR: 71594 Github-PR-URL: #71594 Branch-name: backport/block-supports-background-non-string-attribute-check
dmsnell
force-pushed
the
backport/block-supports-background-non-string-attribute-check
branch
from
d994faf to
8ca7cfa
Compare
dmsnell
added
the
Backport from WordPress Core
|
Flaky tests detected in 54564ab. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17633178357
|
Mamaduka
approved these changes
Sep 11, 2025
dmsnell
added a commit
that referenced
this pull request
Sep 11, 2025
Trac ticket: Core-59622 This is a backport of WordPress/wordpress-develop#5486, which introduces an additional check for non-string values of the `class` attribute when rendering background support for blocks. This check avoids issuing a warning when a boolean `true` value of the attribute is passed on to `str_ends_with()`. Co-authored-by: Tonya Mork <[email protected]> Co-authored-by: Peter Wilson <[email protected]> Co-authored-by: Jon Surrell <[email protected]> Github-PR: 71594 Github-PR-URL: #71594 Branch-name: backport/block-supports-background-non-string-attribute-check
dmsnell
force-pushed
the
backport/block-supports-background-non-string-attribute-check
branch
from
8ca7cfa to
2ef54b7
Compare
Trac ticket: Core-59622 This is a backport of WordPress/wordpress-develop#5486, which introduces an additional check for non-string values of the `class` attribute when rendering background support for blocks. This check avoids issuing a warning when a boolean `true` value of the attribute is passed on to `str_ends_with()`. Co-authored-by: Tonya Mork <[email protected]> Co-authored-by: Peter Wilson <[email protected]> Co-authored-by: Jon Surrell <[email protected]> Co-authored-by: George Mamadashvili <[email protected]> Github-PR: 71594 Github-PR-URL: #71594 Branch-name: backport/block-supports-background-non-string-attribute-check Trac-ticket: 59622
dmsnell
force-pushed
the
backport/block-supports-background-non-string-attribute-check
branch
from
2ef54b7 to
54564ab
Compare
dmsnell
deleted the
backport/block-supports-background-non-string-attribute-check
branch
adamsilverstein
pushed a commit
to adamsilverstein/gutenberg
that referenced
this pull request
Sep 11, 2025
Trac ticket: Core-59622 This is a backport of WordPress/wordpress-develop#5486, which introduces an additional check for non-string values of the `class` attribute when rendering background support for blocks. This check avoids issuing a warning when a boolean `true` value of the attribute is passed on to `str_ends_with()`. Co-authored-by: Tonya Mork <[email protected]> Co-authored-by: Peter Wilson <[email protected]> Co-authored-by: Jon Surrell <[email protected]> Co-authored-by: George Mamadashvili <[email protected]> Github-PR: 71594 Github-PR-URL: WordPress#71594 Branch-name: backport/block-supports-background-non-string-attribute-check Trac-ticket: 59622
peterwilsoncc
pushed a commit
to peterwilsoncc/gutenberg-build
that referenced
this pull request
Sep 11, 2025
Trac ticket: Core-59622 This is a backport of WordPress/wordpress-develop#5486, which introduces an additional check for non-string values of the `class` attribute when rendering background support for blocks. This check avoids issuing a warning when a boolean `true` value of the attribute is passed on to `str_ends_with()`. Co-authored-by: Tonya Mork <[email protected]> Co-authored-by: Peter Wilson <[email protected]> Co-authored-by: Jon Surrell <[email protected]> Co-authored-by: George Mamadashvili <[email protected]> Github-PR: 71594 Github-PR-URL: WordPress/gutenberg#71594 Branch-name: backport/block-supports-background-non-string-attribute-check Trac-ticket: 59622 Source: WordPress/gutenberg@54564ab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: Core-59622
This is a backport of WordPress/wordpress-develop#5486, which introduces an additional check for non-string values of the
classattribute when rendering background support for blocks.This check avoids issuing a warning when a boolean
truevalue of the attribute is passed on tostr_ends_with().