Core Data: Remove conditions for selector resolutions #71575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +38 B (0%) Total Size: 1.94 MB
ℹ️ View Unchanged
|
Mamaduka
commented
Sep 10, 2025
| function getResolutionsArgs( records, recordsQuery ) { | ||
| const queryArgs = Object.fromEntries( | ||
| Object.entries( recordsQuery ).filter( ( [ k, v ] ) => { | ||
| return [ 'context', '_fields' ].includes( k ) && !! v; |
Member
Author
There was a problem hiding this comment.
There are global parameters; the remaining query fields will be actual query arguments. I'm debating if it's worth extracting into a separate constant.
Mamaduka
requested review from
aduth,
jsnajdr,
priethor,
tyxla and
youknowriad
|
Flaky tests detected in 60e8a7f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17606917953
|
priethor
approved these changes
Sep 11, 2025
Contributor
priethor
left a comment
priethor
left a comment
There was a problem hiding this comment.
Changes in both functionality and tests look good, nothing to add 💯
Mamaduka
force-pushed
the
fix/core-data-resolve-records-with-query
branch
from
60e8a7f to
5447866
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #26629.
Related #71541.
PR removes the conditions for batch resolving selectors after fetching the collection. If consumers fetch the same record with the same global query parameters down the React tree, they will be pre-resolved.
Why?
This should improve performance and prevent additional HTTP queries for UIs like DataViews.
Testing Instructions
Test Snippets
Testing Instructions for Keyboard
Same.