-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Increase taxonomy limit for Terms List dropdown #71569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Co-authored-by: George Mamadashvili <[email protected]>
priethor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @Mamaduka's suggestion; it looks good to me with an unlimited-size query.
As a next step, we should consider lazy loading the subsequent pages in batches, now that core data supports paginating for taxonomy terms.
|
Sorry, @priethor! I just copy/pasted the contributors list and realized you were not listed after the merge 🙇 |
Co-authored-by: coreyworrell <[email protected]> Co-authored-by: Mamaduka <[email protected]>
What?
This increases the taxonomy limit from 10 to
100unlimited (-1).Why?
Currently if your site has over 10 public taxonomies, the Terms List block taxonomy dropdown only shows the first 10, not allowing you to show terms from any other taxonomies.
How?
Adds
per_page: 100to the query.Testing Instructions