Block Editor: Fix stale insertion point reference #71559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
the
[Feature] Inserter
|
Size Change: +26 B (0%) Total Size: 1.93 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 1d58322. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17573116090
|
Contributor
Popovers should now run their onClose callback when unmounted. Does that help fix this? |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @CreativeDive. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
Author
|
@jeryj, unfortunately, that doesn’t fix this case, there’s no “blur” or “focus outside”. The popover unmounts because of parent component’s render condition. |
ramonjd
approved these changes
Sep 10, 2025
Member
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
Nice catch. On trunk the inbetween inserter chokes and never returns!
This PR fixes it for me. I tested in post/site editors. If other folks have no objections LGTM 💯
Before
2025-09-10.11.21.14.mp4
After
2025-09-10.11.22.14.mp4
adamsilverstein
pushed a commit
to adamsilverstein/gutenberg
that referenced
this pull request
Sep 11, 2025
Unlinked contributors: CreativeDive. Co-authored-by: Mamaduka <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: jeryj <[email protected]> Co-authored-by: ndiego <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #65598.
PR fixes stale values for insertion point references, which happens when
BlockPopoverInbetweenunmounts its children.Why?
openRef.current) flag to avoid triggering other insertion points, while Quick Inserter is open. Its value is set totruewhen an inserter is open and resets to default (false) on close.BlockPopoverInbetweenwill unmount its children , which results in a staleopenRefflag, since Popovers don't triggeronClosecallback during unmount.How?
Use a ref callback and reset the reference when the
Insertercomponent unmounts. A bit of a hacky solution, but I couldn't think of anything better without making a breaking change to popovers.Testing Instructions
Testing Instructions for Keyboard
Same
Screenshots or screencast
CleanShot.2025-09-09.at.09.45.17.mp4