Gallery Block: Add E2E test for image randomization #71538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.93 MB ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in a13bece. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17541127763
|
Mamaduka
approved these changes
Sep 9, 2025
Member
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
Tested using the following method and new tests haven't failed a single time.
npm run test:e2e -- test/e2e/specs/editor/blocks/gallery.spec.js --repeat-each=50
talldan
pushed a commit
that referenced
this pull request
Sep 10, 2025
* Gallery Block: Add E2E test for image randomization * Use actually uploaded media * Update test title Co-authored-by: t-hamano <[email protected]> Co-authored-by: Mamaduka <[email protected]>
adamsilverstein
pushed a commit
to adamsilverstein/gutenberg
that referenced
this pull request
Sep 11, 2025
* Gallery Block: Add E2E test for image randomization * Use actually uploaded media * Update test title Co-authored-by: t-hamano <[email protected]> Co-authored-by: Mamaduka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #71432
What?
This PR adds e2e tests to ensure that the "Randomize order" setting of the Gallery block works correctly.
Why?
As commented here, we need to use a regular expression to randomize the images inside the Gallery block.
As a result, if the HTML output by the Image block changes in the future, it may no longer match this regular expression, and randomization may no longer work.
How?
Test that the randomization works in both scenarios, with and without the lightbox effect on the image. These E2E tests inject sequential numbers into the alt text and verify that they do NOT match between the editor and the front-end. It is highly unlikely that the order of the Alt text will ever change on the front end, so these tests will never fail.
Testing Instructions
Run
npm run test:e2e test/e2e/specs/editor/blocks/gallery.spec.jsYou can also make the tests fail intentionally to better understand what it's trying to do: