Refactor Link UI controls with better props#71515
Merged
Conversation
- Change canCreatePage to canAddPage for consistency - Change blockEditingMode to canAddBlock for consistency - Update LinkUITools to use new prop names - Remove conditional rendering logic from renderControlBottom
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
getdave
added
[Type] Code Quality
|
Size Change: +13 B (0%) Total Size: 1.93 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5e2d857. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17490182227
|
scruffian
reviewed
Sep 5, 2025
| focusAddPageButton, | ||
| canCreatePage, | ||
| blockEditingMode, | ||
| canAddPage, |
Contributor
Author
There was a problem hiding this comment.
Consistency with the other one and to distinguish it from the idea of permissions being the only thing that that is regulating the display.
scruffian
approved these changes
Sep 5, 2025
Contributor
scruffian
left a comment
scruffian
left a comment
There was a problem hiding this comment.
Looks good. Not sure about the change in the prop name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #71137
The main purpose is to make it clearer what factors govern the rendering of the Add block and Add page buttons. The component itself shouldn't decide this, it should be simple.
Previously there was a mix where
<LinkUITools>did some of the decision logic internally (i.e. viablockEditingMode) prop and some of it was passed in as props (i.e.canCreatePage).This change standardises the approach.