Command Palette: Register menu navigation based on Core Menu API #71476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
force-pushed
the
command-palette-menu-navigation
branch
from
164ef77 to
1ca0e6f
Compare
|
Size Change: -608 B (-0.03%) Total Size: 1.93 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 50869df. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17480311542
|
t-hamano
force-pushed
the
command-palette-menu-navigation
branch
from
8889f19 to
d6739e1
Compare
t-hamano
changed the title
t-hamano
added
[Feature] Command Palette
No Core Sync Required
t-hamano
commented
Sep 3, 2025
Comment on lines
+19
to
+21
| while ( preg_match( '/<[^>]*>/', $menu_label ) ) { | ||
| $menu_label = preg_replace( '/<[^>]*>.*?<\/[^>]*>|<[^>]*\/>|<[^>]*>/s', '', $menu_label ); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This process was a bit tedious. For example, the "Comments" menu is actually made up of the following HTML, which includes text for screen readers:
Comments <span class="awaiting-mod count-0"><span class="pending-count" aria-hidden="true">0</span><span class="comments-in-moderation-text screen-reader-text">0 Comments in moderation</span></span>The command palette cannot handle labels that contain HTML, so I had to remove the HTML and the content within it.
Contributor
There was a problem hiding this comment.
Isn't there already wp functions to do this kind of things like strip_tags or something.
Contributor
Author
There was a problem hiding this comment.
Unfortunately, as far as I could find, there is no such function, either in WP or PHP functions 😅
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
The wp_strip_all_tags removes text only inside style or script tag:
echo wp_strip_all_tags( 'Hello<span>World</span>' ); // HelloWorld
echo wp_strip_all_tags( 'Hello<script>World</script>' ); // Hello
echo wp_strip_all_tags( 'Hello<style>World</style>' ); // Hello
t-hamano
force-pushed
the
command-palette-menu-navigation
branch
from
ee8a8c4 to
9283fcf
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
added
[Type] Enhancement
youknowriad
reviewed
Sep 3, 2025
| } | ||
| $menu_label = trim( $menu_label ); | ||
|
|
||
| // Only add the menu item if the menu_slug point to a PHP file. |
Contributor
There was a problem hiding this comment.
Can you explain what other cases exist?
Contributor
Author
There was a problem hiding this comment.
The menu_slug can be just a PHP file, an external URL, or just a string as an identifier. Initially, I intended to allow menus that are only PHP files, but I was able to handle all that properly in 1efec2c.
1bded6855dd67c45995d2465248a7661.mp4
youknowriad
approved these changes
Sep 3, 2025
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
This is really cool. I love all the red. I wonder if we should have icons for these "go to" commands, maybe like arrows or something but I'm not sure.
The other thing is that there's a lot of existing custom navigation commands that should probably also be updated to use "go to" (like the ones navigating to specific templates, pages...). I think we need consistency there but these can be addressed separately.
Contributor
Author
I see, I would like to address the above as a follow-up PR. |
shail-mehta
reviewed
Sep 4, 2025
This was referenced Sep 5, 2025
This was referenced Sep 8, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #71318
See: #71318 (comment)
Core backport PR: https://github.com/WordPress/wordpress-develop/pull/9542/files (Needs to be updated along with this PR)
What?
This PR automatically registers screen navigation commands based on the global
$menuand$submenuvariables.Why?
This approach has many advantages, but also some disadvantages.
Pros
current_user_canare registered on the server side, and we don't need to performcanUserchecks on the client side.Cons
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast