Edit Post: Check for meta box container before adding constraints #71423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
|
Size Change: +7 B (0%) Total Size: 1.92 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 76413ee. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17343606906
|
Mamaduka
approved these changes
Sep 1, 2025
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes an error during the initial rendering of
MetaBoxesMainwhen using React 19.Why?
To prepare for React 19 compatibility and to fix an error when using React 19.
See #71336 for the full effort.
See #61521 for the PR where the changes came from.
How?
We're making sure that before applying any constraints to the meta box container, we're making sure that it exists.
The change is harmless and won't have any effect in React 18 since the error will be thrown only with React 19.
We're pulling in a part of #61521 to be landed separately.
Testing Instructions
To actually witness the error in React 19:
git revert 9cd7b845a86f66118446d1dfe8a8463ac89911c9and go through the above testing instructions.Testing Instructions for Keyboard
None
Screenshots or screencast