Terms Query: Add link to term-data block bindings #71376
Conversation
cr0ybot
requested review from
ajitbohra,
fabiankaegy and
spacedmonkey
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mikachan
left a comment
mikachan
left a comment
There was a problem hiding this comment.
Thanks for working on this! 🙌 Works as described!
| "core/paragraph", | ||
| "core/heading", | ||
| "core/image", | ||
| "core/buttons", |
|
Ah, I missed the static analysis check. Looks like |
cr0ybot
force-pushed
the
add/terms-query-block-binding-term-link
branch
from
5e0d1ec to
adf3b4e
Compare
|
@mikachan Whoops, my bad. I've rebased against the primary branch and run the docs build. |
mikachan
force-pushed
the
add/terms-query-block-container
branch
2 times, most recently
from
9cbbd4e to
de054eb
Compare
…lock-binding-term-link
No problem. It looks like the base branch needed updating with the latest from trunk as well, as the Storybook smoke test wasn't running successfully. I've updated the base branch and merged it into this PR, hopefully we'll get all green tests this time. |
mikachan
merged commit b973dc3
into
WordPress:add/terms-query-block-container
3 participants
What?
Adds term link to block bindings.
Why?
This enables use of the button block in a Term Template when using the Terms Query block.
How?
Adds
linkfrom the term entity response to the available block binding keys forterm-data.Testing Instructions
urlAttribute and choose "Link"Testing Instructions for Keyboard
Screenshots or screencast