Types: Update to be compatible with React 19 #71374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
Framework
|
Size Change: 0 B Total Size: 1.92 MB ℹ️ View Unchanged
|
|
Flaky tests detected in a47ef54. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17270878534
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
|
Looks like |
Member
|
Seems like a coincidence. The type changes would have failed at build and shouldn't actually affect the app's behavior. Examining the traces, I see errors related to the inline scripts, but I am unable to reproduce them locally. @sirreal, do you think this could be related to the changes from WordPress/wordpress-develop@62f89e9? Screenshots
|
Member
I did not expect any negative impact from that, the encoding should be equivalent, but I've been surprised before. I also landed some changes to include sourceURL comments in inline scripts that touch this area. I can't commit to look closely before Monday, but if this is not resolved on Monday I'll investigate then. |
Member
Author
|
I don't think these could possibly break any e2e test. These are just compatible type changes, and they don't fail the build. |
Contributor
|
This seems to be the core issue: the Customizer widget editor doesn't launch when
|
Member
|
It does seem like the sourceURL comments are to blame. Revert in WordPress/wordpress-develop#9671. |
Member
|
After the revert in Core the test is passing again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes usage of types that are deprecated in React 19 in favor of their recommended counterparts.
Why?
To prepare for React 19 compatibility.
See #71336 for the full effort.
See #61521 for the PR where these commits are coming from.
How?
We're removing usage of a few types that were deprecated in React 19 in favor of their recommended counterparts:
ReactChild:ReactElement | number | stringReactNodeArray:ReadonlyArray< ReactNode >ReactFragment:Iterable< ReactNode >ReactText:number | stringPulls in part of #61521 to be landed separately.
Testing Instructions
Verify all checks are green.
Testing Instructions for Keyboard
None
Screenshots or screencast
None