Audio and Video: Hide caption controls in contentOnly mode #71368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
the
[Type] Bug
andrewserong
added
[Block] Image
|
Size Change: +27 B (0%) Total Size: 1.92 MB
ℹ️ View Unchanged
|
Contributor
|
Text tracks in principle should be internal to the video (like captions files: they get applied inside the video window) so they don't alter the design in any way. I'm inclined to treat these as alt text for images and keep them editable, because like alt text they're an a11y feature. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
Sure, I can remove the check for the text tracks. I mostly included it based on frequency with which folks might use the control, but don't feel strongly about it! |
andrewserong
changed the title
Contributor
Author
Done! |
Contributor
|
Tbh I'm not sure about any of the rules of write mode 😅 but I know we do want to keep the Image alt text because we even made a special component for it here. Video captions and descriptions are a similar a11y feature so we might as well be consistent and make them available. I'm not even sure it makes sense to not allow adding captions to images when we want to allow adding content to quotes, galleries, lists, etc. Captions aren't decorative and the need for a caption might depend on the image being shown. But again, the rules are very unclear 🤷 |
tellthemachines
approved these changes
Aug 27, 2025
Contributor
tellthemachines
left a comment
tellthemachines
left a comment
There was a problem hiding this comment.
Code LGTM and is working well! Caption controls don't show in write mode (or in zoom out mode for that matter). Captions still display if added in design mode.
|
Flaky tests detected in bd675b5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17257071814
|
Contributor
Author
Same, I think we're feeling some of these things out as we go. While we still have the mode largely hidden behind an experiment, I'm comfortable enough with landing some of these changes (and reverting where needed). It'll be interesting to see overall how it feels as we attempt to simplify / hide things. It could be that we wind up having to make some of these things visible again if it feels like we've pulled too much back. In any case, thanks for the discussion and review here! I'll merge this in now. |
andrewserong
deleted the
update/audio-and-video-blocks-to-hide-caption-and-text-tracks-controls-in-content-only-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #65778
In the Audio and Video blocks hide the caption controls when in contentOnly mode.
Why?
As discussed in #65778 (comment) the idea is that write mode is for editing existing content, not introducing new material such as captions. The Image block already hides the Caption control, so this PR extends that to the Audio and Video blocks, helping to improve consistency.
How?
useBlockEditingModecalls to the Video and Audio blocks and only show the Caption controls when we're in the default block editing mode (hasNonContentControls, which is the same check used in the Image block)Testing Instructions
Screenshots or screencast