Skip to content

Accordion: Add example block preview #71365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
t-hamano merged 2 commits into from
Sep 19, 2025
Merged

Accordion: Add example block preview #71365

t-hamano merged 2 commits into from
Sep 19, 2025

Conversation

@himanshupathak95
Copy link
Contributor

@himanshupathak95 himanshupathak95 commented Aug 26, 2025 •
edited
Loading

What?

Closes #71354

Updates the Accordion block preview to display two example headers.

Why?

Previously, the Accordion block preview was empty, making it difficult to visualize how accordion sections would appear. This change improves clarity for users by showing a more realistic example.

How?

Defines two core/accordion-content inner blocks in the Accordion block’s example field, each with its own header.

Testing Instructions

  1. Enable experimental blocks ( Gutenberg > Experiments > enable Blocks: add experimental blocks )
  2. Open a post or page.
  3. Check the Accordion block example preview.
  4. Confirm that the block preview displays two example headers.

Screenshots

Before After
image image

@himanshupathak95 himanshupathak95 marked this pull request as ready for review August 27, 2025 08:35
@github-actions
Copy link

github-actions bot commented Aug 27, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: himanshupathak95 <[email protected]>
Co-authored-by: Soean <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@himanshupathak95 himanshupathak95 force-pushed the fix/71354-accordion-block-preview branch from ca5da70 to 63acf80 Compare August 27, 2025 08:37
Soean
Soean previously requested changes Aug 27, 2025
View reviewed changes
Copy link
Member

@Soean Soean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have two minor suggestions:

  • The content should be translatable. Please wrap the content in a __( 'English text' ) function.
  • We also should use a more generic or Lorem ipsum text. We can use the other blocks as a reference.

@Soean Soean added [Type] Enhancement A suggestion for improvement. [Block] Accordion Affects the Accordion Block labels Aug 27, 2025
@himanshupathak95 himanshupathak95 force-pushed the fix/71354-accordion-block-preview branch from 233024f to 2f1cb2f Compare August 28, 2025 07:56
@himanshupathak95
Copy link
Contributor Author

himanshupathak95 commented Aug 28, 2025

  • The content should be translatable. Please wrap the content in a __( 'English text' ) function.

I completely missed this one. Thanks, @Soean, for pointing this out.

@himanshupathak95 himanshupathak95 requested a review from Soean August 28, 2025 09:25
@Mamaduka Mamaduka mentioned this pull request Aug 29, 2025
Merged
t-hamano
t-hamano approved these changes Sep 19, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@himanshupathak95, can you rebase this PR on top of trunk before merging?

@t-hamano t-hamano dismissed Soean’s stale review September 19, 2025 03:06

Feedback has been addressed

@himanshupathak95 himanshupathak95 force-pushed the fix/71354-accordion-block-preview branch from 2f1cb2f to f9ca7fd Compare September 19, 2025 07:25
@t-hamano t-hamano merged commit 268258f into WordPress:trunk Sep 19, 2025
67 checks passed
@github-actions github-actions bot added this to the Gutenberg 21.8 milestone Sep 19, 2025
adamsilverstein pushed a commit to adamsilverstein/gutenberg that referenced this pull request Sep 22, 2025
@himanshupathak95 @t-hamano @adamsilverstein
Accordion: Add example block preview (WordPress#71365)
4837b0d 
* Accordion: Add example block preview

* Accordion: Make example preview texts translatable and generic

Co-authored-by: himanshupathak95 <[email protected]>
Co-authored-by: Soean <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t-hamano t-hamano t-hamano approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

@Soean Soean Awaiting requested review from Soean

Assignees

No one assigned

Labels

[Block] Accordion Affects the Accordion Block [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

Gutenberg 21.8

Development

Successfully merging this pull request may close these issues.

Accordion Block: Add block example

3 participants

@himanshupathak95 @Soean @t-hamano