Global Styles: Remove unecessary useEffect from ScreenStyleVariations#71344
Merged
Global Styles: Remove unecessary useEffect from ScreenStyleVariations#71344
Conversation
t-hamano
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -41 B (0%) Total Size: 1.92 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Aug 27, 2025
Contributor
Author
|
@Mamaduka Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
What? Why? How?
The styles screen enables the zoom out mode and forces the device preview to be desktop. However, the correct value is
Desktop, notdesktop, so I'm not sure why this effect is necessary in the first place. Additionally, thegetDeviceTypeselector forces the Desktop view when zoomed out mode is enabled, so there seems to be no need to explicitly force the Desktop view.Maybe this code solved the problem for some reason at the time, but everything appears to work correctly without this side effect.
Testing Instructions
Verify that the issue reported in #65991 has not reoccurred.
Screenshots or screencast
366b2f89bf2a44cb73658a0383b1b1c3.mp4