Editor: Improve the 'Design' sidebar panel performance #71333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Performance
Mamaduka
commented
Aug 25, 2025
| }, [] ); | ||
| const { editEntityRecord } = useDispatch( coreStore ); | ||
| const availablePatterns = useAvailablePatterns( record ); | ||
| const availablePatterns = useAvailablePatterns( { area, name, slug } ); |
Member
Author
There was a problem hiding this comment.
Initially, I thought of using memoization and passing the partial record, but I think this way it's more visible what data is expected.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
Author
|
Side note: Jumpiness caused by the "Content" panel height change is still annoying, but that might be hard to fix without a complete redesign. ScreencastCleanShot.2025-08-25.at.12.37.34.mp4 |
|
Size Change: +31 B (0%) Total Size: 1.92 MB
ℹ️ View Unchanged
|
Mamaduka
force-pushed
the
fix/post-transform-panel-perf
branch
from
fd1b9bc to
6f7b58c
Compare
|
Flaky tests detected in 723f091. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17207730649
|
Mamaduka
force-pushed
the
fix/post-transform-panel-perf
branch
from
6f7b58c to
723f091
Compare
Member
|
Retriggered the failing tests, none of the failures appears related |
Member
Author
|
Thanks for the review, @tyxla!
Yes. Seems like Docker server issues, which happen from time to time. I'm going to merge this. There's the same failure on the trunk. We don't have control over the Docker server status :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
"Stacks" on #71332.PR tries to improve the "Design" sidebar panel performance by avoiding unnecessary re-renders every time a record is updated. The data needed for filtering patterns doesn't change often, and the panel doesn't have to react to content edits.
Rendering previews can be expensive. Components should avoid re-rendering them when possible.
Why?
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast
Templates
Before
CleanShot.2025-08-25.at.12.41.44.mp4
After
CleanShot.2025-08-25.at.12.42.20.mp4
Template Parts
Before
CleanShot.2025-08-25.at.11.58.13.mp4
After
CleanShot.2025-08-25.at.11.57.23.mp4