-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Template Part: Display icons correctly when in placeholder state #71327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Size Change: +2 B (0%) Total Size: 1.92 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good to me. Thanks for the fix.
Mamaduka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, @t-hamano!
|
Flaky tests detected in d380ad4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17190000478
|
Follow-up #66459
What?
Why?
#66549 has changed the way to get the default template areas, from the editor store to the REST API:
This means that the conversion from icon string to React element that the
__experimentalGetDefaultTemplatePartAreasselector used to do internally must now be done explicitly.Although the icons for block variations were converted correctly, the icon for placeholders remained as a string, so it was treated as a dash icon, and the intended icon was not displayed.
How?
Use
getTemplatePartIconfunction inside theuseTemplatePartArea. This hook is used to get the icon and label for the Placeholder component.Testing Instructions