Command Palette: Enqueue assets globally #71264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Code Quality
t-hamano
commented
Aug 20, 2025
Comment on lines
-94
to
-104
| add_settings_field( | ||
| 'gutenberg-command-palette-everywhere', | ||
| __( 'Command Palette: enable everywhere', 'gutenberg' ), | ||
| 'gutenberg_display_experiment_field', | ||
| 'gutenberg-experiments', | ||
| 'gutenberg_experiments_section', | ||
| array( | ||
| 'label' => __( 'Enables the Command Palette everywhere in the admin dashboard.', 'gutenberg' ), | ||
| 'id' => 'gutenberg-command-palette-everywhere', | ||
| ) | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
This setting does nothing anymore, but I forgot to remove it 😅
|
Size Change: -53 B (0%) Total Size: 1.92 MB
ℹ️ View Unchanged
|
t-hamano
changed the title
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in d8ecc4b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17143369042
|
youknowriad
approved these changes
Aug 20, 2025
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
This is working great for me. I don't see any issues.
One thing I noticed is that I would love if we do some kind of audit/unification of all the navigation commands. Maybe all of them should be "go to something" and work in all screens. Right now it's a bit inconsistent. I think we use "open something" a bit more but sometimes we do nothing like just "styles"...
Contributor
Author
|
I forgot to delete the
Does this mean that navigation-related commands currently in the |
Contributor
That sounds like a good approach to me, also unifying labels... |
Contributor
Author
I see, I'd like to submit an issue to address that later 👍 |
Contributor
Author
|
I'd like to add this PR to the 6.9 Editor Tasks board so that we don't forget to commit the core patch in 6.9 Beta 1 release. |
github-project-automation
bot
moved this to 🔎 Needs Review
in WordPress 6.9 Editor Tasks
t-hamano
moved this from 🔎 Needs Review
to 🎯 Needs Core Commit
in WordPress 6.9 Editor Tasks
Contributor
Author
Since the core ticket has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the core command initialization and registration code from the
edit-postandedit-sitepackages and enqueues command-related assets globally.Why?
We need to eliminate the Post Editor and Site Editor-specific processing and register commands with one code.
How?
@wordpress/edit-postand@wordpress/edit-site:CommandMenucomponent and the core commands registration process@wordpress/core-commandsdependencyTesting Instructions
There is absolutely no change in behaviour. Confirm that all commands work correctly in the post editor, site editor, and all admin pages.