Embed block: Add example preview#71014
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
yogeshbhutkar
added
[Type] Enhancement
yogeshbhutkar
left a comment
yogeshbhutkar
left a comment
There was a problem hiding this comment.
In my opinion, "Block Preview" works by giving an impression of how the block might look on the front-end. One can derive this by observing the example preview of other blocks.
Since the placeholder isn't rendered on the front-end at all, I believe it's probably better for the embed blocks to show "No preview available" instead of showing the placeholders as a preview (until we're able to show the actual previews of embeds for all the variations). However, I'd prefer to get a second review from someone more knowledgeable.
Also, please note that this change will apply to all the corresponding block variations.
|
Got it, Thank you for the clarification @yogeshbhutkar. |
2 participants
Part of #64707
What?
This PR adds an example attribute to the
Embed blockto provide a block preview in the inserter.Testing Instructions
Screenshots