Skip to content

Lower PostPanelRow style specifity #70981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alshakero wants to merge 2 commits into from
Closed

Lower PostPanelRow style specifity #70981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7623b9
Lower PostPanelRow style specifity
alshakero Jul 30, 2025
b62c6b8
Switch to props config instead of CSS
alshakero Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/editor/src/components/post-panel-row/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const PostPanelRow = forwardRef( ( { className, label, children }, ref ) => {
<HStack
className={ clsx( 'editor-post-panel__row', className ) }
ref={ ref }
align="flex-start"
>
{ label && (
<div className="editor-post-panel__row-label">{ label }</div>
Expand Down
6 changes: 2 additions & 4 deletions packages/editor/src/components/post-panel-row/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,14 @@
.editor-post-panel__row {
width: 100%;
min-height: $grid-unit-40;
justify-content: flex-start !important;
align-items: flex-start !important;
}

.editor-post-panel__row-label {
width: 38%;
flex-shrink: 0;
min-height: $grid-unit-40;
display: flex;
align-items: center;
align-items: flex-start;
Copy link
Contributor

@t-hamano t-hamano Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the parent now has a new flex-start style, is it safe to remove this style?

padding: 6px 0; // Matches button to ensure alignment
line-height: $grid-unit-05 * 5;
hyphens: auto;
Expand All @@ -20,7 +18,7 @@
flex-grow: 1;
min-height: $grid-unit-40;
display: flex;
align-items: center;
align-items: flex-start;
Comment on lines -23 to +21
Copy link
Contributor

@t-hamano t-hamano Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/WordPress/gutenberg/pull/70981/files#r2259672328


.components-button {
max-width: 100%;
Expand Down
Loading