Skip to content

PaletteEdit: Fill available space with input field #70935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ajitbohra merged 2 commits into from
Jul 28, 2025
Merged

PaletteEdit: Fill available space with input field #70935

ajitbohra merged 2 commits into from
Jul 28, 2025

Conversation

@t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Jul 28, 2025 •
edited
Loading

What?

A small improvement to correctly layout elements when editing palettes.

Why?

My guess is that the natural behavior is for the input field width to fill all available horizontal space.

Testing Instructions

Site Editor

  • Appearance > Editor > Styles > Colors > Edit Palette > Custom Section
  • Click the Add color button
Before After
image image

Storybook

http://localhost:50240/?path=/docs/components-paletteedit--docs

Before After
image image

@t-hamano t-hamano self-assigned this Jul 28, 2025
@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Package] Components /packages/components labels Jul 28, 2025
@t-hamano t-hamano requested a review from a team July 28, 2025 09:23
@t-hamano t-hamano marked this pull request as ready for review July 28, 2025 09:23
@t-hamano t-hamano requested a review from ajitbohra as a code owner July 28, 2025 09:23
@github-actions
Copy link

github-actions bot commented Jul 28, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <[email protected]>
Co-authored-by: ajitbohra <[email protected]>
Co-authored-by: mirka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

ajitbohra
ajitbohra approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@ajitbohra ajitbohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

mirka
mirka approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ajitbohra ajitbohra merged commit 8613780 into trunk Jul 28, 2025
66 checks passed
@ajitbohra ajitbohra deleted the palette-edit-grow-input-field branch July 28, 2025 13:02
@github-actions github-actions bot added this to the Gutenberg 21.4 milestone Jul 28, 2025
adamsilverstein pushed a commit to adamsilverstein/gutenberg that referenced this pull request Jul 31, 2025
@t-hamano @adamsilverstein
PaletteEdit: Fill available space with input field (WordPress#70935)
7e1c8fc 
* PaletteEdit: Fill available space with input field

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mirka mirka mirka approved these changes

@ajitbohra ajitbohra ajitbohra approved these changes

Assignees

@t-hamano t-hamano

Labels

[Package] Components /packages/components [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

Gutenberg 21.4

Development

Successfully merging this pull request may close these issues.

4 participants

@t-hamano @mirka @ajitbohra