Migrate plugins package to TS#70773
Merged
manzoorwanijk merged 3 commits intoWordPress:trunkfrom Jul 22, 2025
Merged
Conversation
40 tasks
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Comment on lines
11
to
28
| interface PluginErrorBoundaryProps { | ||
| /** | ||
| * The name of the plugin that may encounter an errors. | ||
| */ | ||
| name: string; | ||
| /** | ||
| * The child components to render. | ||
| */ | ||
| children: ReactNode; | ||
| /** | ||
| * Callback function called when an error occurs. | ||
| */ | ||
| onError?: ( name: string, error: Error ) => void; | ||
| } | ||
|
|
||
| interface PluginErrorBoundaryState { | ||
| hasError: boolean; | ||
| } |
Member
There was a problem hiding this comment.
If we,
- Use
React.ReactNodewithout importing from'react' - Move these two interfaces to a
types.tsfile in the same directory, and then use
import type {
PluginErrorBoundaryProps as Props,
PluginErrorBoundaryState as State,
} from './types';
export class PluginErrorBoundary extends Component< Props, State > {
//
}That way, we can preserve the git history of the file.
manzoorwanijk
approved these changes
Jul 21, 2025
Member
manzoorwanijk
left a comment
manzoorwanijk
left a comment
There was a problem hiding this comment.
This looks good now. Thank you for making the suggested changes.
USERSATOSHI
pushed a commit
to USERSATOSHI/gutenberg
that referenced
this pull request
Jul 23, 2025
Co-authored-by: dhruvikpatel18 <[email protected]> Co-authored-by: manzoorwanijk <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of: #67691
Migrating the plugins package to Typescript.
Why?
Type safety.
Testing Instructions
Type check