Skip to content

a11y: Comments Pagination Nav Wrapper #70730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
t-hamano merged 2 commits into from
Jul 16, 2025
Merged

a11y: Comments Pagination Nav Wrapper #70730

t-hamano merged 2 commits into from
Jul 16, 2025

Conversation

@Adi-ty
Copy link
Contributor

@Adi-ty Adi-ty commented Jul 15, 2025 •
edited
Loading

What?

Closes #70729

This PR updates the Comments Pagination block to use a <nav> element with aria-label="Comments pagination" as its wrapper, instead of a <div>

Why?

  • Improves accessibility by providing a navigation landmark
  • Aligns the block’s markup with the core the_comments_pagination() function and the Query Pagination block.

How?

  • Changes the render function to output with aria-label="Comments pagination" and the appropriate classes.
  • Uses get_block_wrapper_attributes() to add the aria-label and class attributes.

Testing Instructions

  1. Add a Comments Pagination block to a post or template.
  2. View the front end and inspect the markup.
  3. Confirm the pagination is wrapped in a <nav> element with aria-label="Comments pagination".

@Adi-ty Adi-ty marked this pull request as ready for review July 15, 2025 11:39
@github-actions
Copy link

github-actions bot commented Jul 15, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Adi-ty <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added [Type] Enhancement A suggestion for improvement. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Block] Comments Pagination Affects the Comments Pagination Block labels Jul 16, 2025
t-hamano
t-hamano approved these changes Jul 16, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick fix.

P.S. I recommend that you don't omit the Testing Instructions section. Without this section, reviewers may not know what to test and how to test it.

@t-hamano t-hamano merged commit 20fd653 into WordPress:trunk Jul 16, 2025
75 of 76 checks passed
@github-actions github-actions bot added this to the Gutenberg 21.3 milestone Jul 16, 2025
@Adi-ty
Copy link
Contributor Author

Adi-ty commented Jul 16, 2025

Thanks @t-hamano, I've just added the Testing Instructions and will keep that in mind for next time.

USERSATOSHI pushed a commit to USERSATOSHI/gutenberg that referenced this pull request Jul 23, 2025
@Adi-ty @t-hamano @USERSATOSHI
a11y: Comments Pagination Nav Wrapper (WordPress#70730)
afd43ba 
* fix: use <nav> with aria-label for Comments Pagination block for accessibility

Fixes WordPress#70729

* fix: update aria-label for Comments Pagination block to improve accessibility

Co-authored-by: Adi-ty <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t-hamano t-hamano t-hamano approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees

No one assigned

Labels

[Block] Comments Pagination Affects the Comments Pagination Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

Gutenberg 21.3

Development

Successfully merging this pull request may close these issues.

Accessibility improvements to the Comments Pagination block

2 participants

@Adi-ty @t-hamano