Data Core: Add Media selector documentation#70631
Closed
Infinite-Null wants to merge 1 commit intoWordPress:trunkfrom
Closed
Data Core: Add Media selector documentation#70631Infinite-Null wants to merge 1 commit intoWordPress:trunkfrom
Infinite-Null wants to merge 1 commit intoWordPress:trunkfrom
Conversation
Member
|
@Infinite-Null, it's probably best to avoid promoting more selector shortcuts for now. See: #64215 (comment). P.S. I added the status blocked to the tracking issue. |
Member
|
@Infinite-Null, it might be better to close this PR for now. We can resolve the work once the problems with shortcut selectors are resolved. |
Contributor
Author
|
Sure @Mamaduka 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #64215
What?
This PR manually adds documentation for the
getMediadynamically generated selector in thecore/datastore.Why?
The
getMediaselector is missed by the docgen tool and provides a much more user-friendly interface compared to the underlyinggetEntityRecord( 'root', 'media', id )selector that powers it.